[Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118306





--- Comment #7 from Christophe Dumez <dchris at gmail.com>  2013-07-03 05:35:17 PST ---
(From update of attachment 205918)
View in context: https://bugs.webkit.org/attachment.cgi?id=205918&action=review

>>> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
>>> +    if (url.find("dumpAsText/") != WTF::notFound || mimeType == "text/plain")
>> 
>> Don't you mean "&& mimeType != "text/plain" ?
> 
> No, because we should dumpAsText if the "dumpAsText/" string is found (hence the first part) or if the mimeType is "text/plain"
> 
> In the dumpAsText(false) call the 'false' means do not dump pixels.

Ok. "dumpAsText(false)" confused me indeed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.