[Webkit-unassigned] [Bug 117998] need mechanism to detect (partially) hidden blocked plugins

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 2 15:45:18 PDT 2013


--- Comment #5 from Dean Jackson <dino at apple.com>  2013-07-02 15:47:16 PST ---
(From update of attachment 205926)
View in context: https://bugs.webkit.org/attachment.cgi?id=205926&action=review

In general I think this is ok - I can't really think of many better ways to do it. I worry about a lot of edge cases though: like an element animating over the plugin, pointer-events, an overlay that completely obscures the element but itself is invisible to pointer events (and thus will not hit test in your algorithm), etc.

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:304
> +        if (style->opacity() < 0.1)
> +            return true;

I'm confused by this: if any of the ancestors have less than 10% opacity, then this element is obscured?

I assume you're trying to find if something up the parent chain is making this object mostly transparent. Maybe you should accumulate (multiply) the opacity as you go? 0.5 * 0.5 * 0.5 * 0.5 * 0.5 is getting pretty hard to see.

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:332
> +    hit = docRenderer->hitTest(request, location, result);

I think this will fail if something up the chain has set pointer-events to none.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list