[Webkit-unassigned] [Bug 118297] [ATK] Leak: leaks in AccessibilityUIElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118297





--- Comment #11 from Christophe Dumez <dchris at gmail.com>  2013-07-02 07:46:41 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 205904 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=205904&action=review
> > 
> > > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:315
> > > +    GOwnPtr<char> attributeString(attributeSetToString(atk_object_get_attributes(ATK_OBJECT(m_element))));
> > 
> > There is indeed a leak here though. According to the doc:
> > https://developer.gnome.org/atk/unstable/AtkObject.html#atk-object-get-attributes
> > 
> > "This atkattributeset should be freed by a call to atk_attribute_set_free()."
> 
> Yes, I've just been discussing with Mario how to resolve this.  The best fix requires a specialisation of GOwnPtr so I'll propose that in a separate bug (coming shortly).

I agree, probably in a new Source/WebCore/accessibility/atk/GOwnPtrAtk.h ?

See for example:
Source/WebCore/platform/network/soup/GOwnPtrSoup.*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.