[Webkit-unassigned] [Bug 118293] [webkitpy] Add run-tests-touched-by-attachment command

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118293


János Badics <jbadics at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205907|                            |review?
               Flag|                            |




--- Comment #1 from János Badics <jbadics at inf.u-szeged.hu>  2013-07-02 06:47:15 PST ---
Created an attachment (id=205907)
 --> (https://bugs.webkit.org/attachment.cgi?id=205907&action=review)
WIP patch

The tool can be run by
'Tools/Scripts/webkit-patch run-tests-touched-by-attachment [ATTACHMENT_ID]'

At the current state, the tool gets the paths of modified expected txt/png files. Then it determines the filename without the '-expected' suffix and the file extension. _test_relative_dir() determines the relative generic directory path for the given test, e.g.
LayoutTests/platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.txt ->
editing/deleting/
Then _tests_in_dir gets the paths of all the tests found in this directory. As a last step, the loop in _first_generic_by_filename() gets the first match to the given file name.
I know it's a bit ineffective, but we have to look up the extension for the given test file name, since a lot of extensions are supported for test files (htm, html, xhtml, etc.).

Further modifications are also needed, especially the ones recommended by Ryosuke Niwa at https://bugs.webkit.org/show_bug.cgi?id=117831

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.