[Webkit-unassigned] [Bug 109661] Implement CoordinatedSurface for Threaded Coordinated Graphics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109661





--- Comment #15 from Jae Hyun Park <jae.park at company100.net>  2013-07-01 22:10:45 PST ---
(In reply to comment #13)
> (From update of attachment 205848 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205848&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:58
> > +    GraphicsContext* context = beginPaint(rect);
> > +    client->paintToSurfaceContext(context);
> > +    endPaint();
> 
> It would be better if this was all in one function. Otherwise it may look like beginPaint and endPaint can be called outside the context of paintToSurface.

I agree. Removed beginPaint and endPaint.
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:77
> > +#if USE(TEXTURE_MAPPER)
> 
> I think we can remove these in coordinated-graphics code.
Fixed.


Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.