[Webkit-unassigned] [Bug 117895] [v2.1.2] GTK2 build fails for undefined GDK_IS_X11_DISPLAY

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 09:20:28 PDT 2013


Alberto Garcia <agarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |agarcia at igalia.com,
                   |                            |cgarcia at igalia.com

--- Comment #4 from Alberto Garcia <agarcia at igalia.com>  2013-07-01 09:22:26 PST ---
Thanks for the patch!

Can you please rework a bit the ChangeLog entry? I should be
something like this:

   Bug Title
   Bug URL

   Reviewed by NOBODY (OOPS!).

   Long description.

   * WebCoreSupport/ChromeClientGtk.cpp:

About the change itself, I think it's fine. As a minor thing, you can
also put everything in one line, e.g.

   #if defined(GDK_WINDOWING_X11) && !defined(GDK_IS_X11_DISPLAY)

I think it would be a good idea to have all the compatibility code
together in the same file, but we don't have that at the moment.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list