[Webkit-unassigned] [Bug 119080] [CSS Masking] -webkit-mask-repeat: round does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119080





--- Comment #3 from Dirk Schulze <krit at webkit.org>  2013-07-31 05:38:35 PST ---
(From update of attachment 207633)
View in context: https://bugs.webkit.org/attachment.cgi?id=207633&action=review

> Source/WebCore/ChangeLog:7
> +        Added the round functionality to -webkit-mask-repeat.
> +        https://bugs.webkit.org/show_bug.cgi?id=119080
> +

Please add some more lines of comments what you did and how it influenced the bahavior on the dimension calculation code.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1312
> +    if (backgroundRepeatX == RoundFill && positioningAreaSize.width() > 0 && fillTileSize.width() > 0) {

Doesn't background call the same code path? When it works for background, why doesn't it work for -webkit-mask? If the code exists for background somewhere, we should make sure that we reuse the code.

Do we have tests for background-repeat and "round"?

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1314
> +        int nrTiles = ceil((double)positioningAreaSize.width() /
> +            fillTileSize.width());

why do you split the line here? You don't do it later?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.