[Webkit-unassigned] [Bug 119306] New: Only traverse the ShadowRoots once during recalcStyle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 20:35:26 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119306

           Summary: Only traverse the ShadowRoots once during recalcStyle
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, simon.fraser at apple.com,
                    akling at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/822b9208b529009dbbb5cd53ded62edcb61735bc
if it's applicable.

Element::recalcStyle called ElementShadow::childNeedsStyleRecalc and needsStyleRecalc
both of which traversed all the ShadowRoots before it decided to traverse the
list of ShadowRoots again. ElementShadow::recalcStyle also called recalcStyle
on each ShadowRoot even if it didn't need it which meant we'd walk all the children
of every ShadowRoot on an Element as soon a single one needed a style recalc.

We can delete a bunch of code, remove the template from shouldRecalcStyle, and
stop doing all this extra traversing by merging the loop into Element::recalcStyle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list