[Webkit-unassigned] [Bug 119287] New: Remove non-sensical code to force body/documentElement layout in FrameView::layout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 16:10:26 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119287

           Summary: Remove non-sensical code to force body/documentElement
                    layout in FrameView::layout
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: hyatt at apple.com, koivisto at iki.fi,
                    simon.fraser at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/efb3a87ef7691e129f3c50895cf6f6ad89f15e19

FrameView::layout() should only be about updating the layout of renderers which
need a layout update. It should not need to force renderers to layout.  If it's
doing that, then some other code has failed to correctly invalidate the layout
of those renderers.

This used to be for FrameFlattening (which is still part of seamless), but has morphed over the years.  I'm not sure it was ever really needed.  See:
http://trac.webkit.org/browser/trunk/WebCore/page/FrameView.cpp?annotate=blame&rev=73116#L501

And:
http://trac.webkit.org/changeset/73117

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list