[Webkit-unassigned] [Bug 33226] Indent inside li with br's changes order and creates new lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33226


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207690|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-07-30 12:33:45 PST ---
(From update of attachment 207690)
View in context: https://bugs.webkit.org/attachment.cgi?id=207690&action=review

review- because this seems to have a bad cast in it and because there is no test case; we require test cases for WebKit bug fixes.

> Source/WebCore/editing/IndentOutdentCommand.cpp:73
> +    Element* currentElement = static_cast<Element*>(lastNodeInSelectedParagraph);

Should use toElement. But what guarantees this is an element, not a non-element node?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.