[Webkit-unassigned] [Bug 119137] [CSS Regions] Selecting text through different regions flow does not match with highlight

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119137





--- Comment #6 from Javier Fernandez <jfernandez at igalia.com>  2013-07-30 11:37:21 PST ---
(In reply to comment #5)
> (From update of attachment 207639 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207639&action=review
> 
> > Source/WebCore/ChangeLog:1
> > +2013-07-29  Javier Fernandez  <jfernandez at igalia.com>
> > LayoutTests/ChangeLog:1
> > +2013-07-29  Manuel Rego Casasnovas  <rego at igalia.com>
> 
> The author is different for the 2 changelogs. Is it intentional?
> 

The WebCore patch was extracted, actually, from the patch posted at bug #106817, but, since it covers only a specific case, a new and simpler test was added. I guess that's the reason, but rego should tell. 

> > Source/WebCore/rendering/RenderView.cpp:-728
> > -    if ((start && end) && (start->flowThreadContainingBlock() != end->flowThreadContainingBlock()))
> 
> I think at the point we remove this condition we should be able to select content through different regions.

Actually, this patch makes the highlighting to behave exactly as yours, but it solved at editing side, which I think is more appropriated and solves also other issues related to the selected content. More on this below.

> 
> I have some questions.
> 
> Wouldn't be easier to fix the highlighting of the selection? Or do you already have a plan to achieve that based on the actual patch? (Is this change necessary beside with the work in bug #106817 ?)

As I said before, this patch solves the highlighting issue as well. The approach followed in the patch for bug #106817 is based on multi-range, which was strongly rejected by some reviewers. Actually, there is an ongoing thread about this matter in the mailing list, still without many contributions, though. 

With this patch, when user selects content starting outside the region and ending inside, not only the highlighting works, but also the content inside the region is skipped too, so we think is more coherent which what user would expect.

It's important to notice that both, this patch and the one you provided for bug #105641 assume we won't allow the user to select content from different Flow Threads, which we thought it was a good start.  However, given the negative feedback we have been getting from the multi-range approach, we are thinking on keeping the selection as DOM based, even when the user would get weird selected content when flow named nodes are inside the selection boundaries.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.