[Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118445





--- Comment #36 from Arunprasad Rajkumar <arurajku at cisco.com>  2013-07-30 04:59:37 PST ---
(In reply to comment #35)
> (In reply to comment #31)
> > > I don't see any use case where a 0 key to a QKeyEvent is expected, so this could allow to shape legacy web key events.
> > 
> > nativeVirtualKey() property may have some other value in window systems like X11(xcb_keycode_t), DirectFB,.. If I say simply, Allen(& me too) don't want to break the existing behavior unless QtWebKit embedder decided to override by enabling a QWebSettings :)
> 
> The switch of behavior would be done when QKeyEvent::key() returns 0, which isn't a normal use case at all in Qt, and should never happen. What I mean is that using a QWebSettings + key() = 0 should have the same scope of effect as just key() = 0.
> 
> I just don't like this boolean passing of the QWebSetting down to PlatformKeyboardEvent on each event.
> 
> (btw, his name is Allan, not Allen)

(In reply to comment #35)
> (In reply to comment #31)
> > > I don't see any use case where a 0 key to a QKeyEvent is expected, so this could allow to shape legacy web key events.
> > 
> > nativeVirtualKey() property may have some other value in window systems like X11(xcb_keycode_t), DirectFB,.. If I say simply, Allen(& me too) don't want to break the existing behavior unless QtWebKit embedder decided to override by enabling a QWebSettings :)
> 
> The switch of behavior would be done when QKeyEvent::key() returns 0, which isn't a normal use case at all in Qt, and should never happen. What I mean is that using a QWebSettings + key() = 0 should have the same scope of effect as just key() = 0.

True. But in the new patch, I modified to use nativeVirtualKey always incase settings is enabled. Because there is a use case to override the keyCode value for Qt's standard key also.

> 
> I just don't like this boolean passing of the QWebSetting down to PlatformKeyboardEvent on each event.
> 
I agree with you. It causes QList lookup during each KeyboardEvent. But settings is became necessary for the new implementation.


> (btw, his name is Allan, not Allen)
sorry :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.