[Webkit-unassigned] [Bug 118185] Gmail reply email - Bold and Italic style get stuck

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118185





--- Comment #25 from Ryosuke Niwa <rniwa at webkit.org>  2013-07-29 20:18:56 PST ---
(From update of attachment 207506)
View in context: https://bugs.webkit.org/attachment.cgi?id=207506&action=review

> LayoutTests/ChangeLog:12
> +        (createNewLine):
> +        Added new utility functions to be able to log data and to be able to
> +        create line breaks between log statements

Why are we line breaking after the colon?

> LayoutTests/ChangeLog:19
> +        Layout tests added to test bold/italic style toggling on a content
> +        with mixed editability

You should probably mention this at the beginning of the entry after Reviewed by line.

> LayoutTests/editing/editing.js:936
> +    var newItem = document.createTextNode(text);
> +    markupResultList.appendChild(newItem);

This isn't right. You need to close the existing list and create a new list.
Inserting a dangling text node without li results in "invalid" markup.

> LayoutTests/editing/editing.js:942
> +function createNewLine() {
> +    var newItem = document.createElement('br');
> +    markupResultList.appendChild(newItem);
> +}

This function name seems too generic. It also has the same problem as separateMarkupResultList.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.