[Webkit-unassigned] [Bug 119189] New: Some cleanup in PropertySlot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119189

           Summary: Some cleanup in PropertySlot
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: barraclough at apple.com


PropertySlot represents a property in one of four states - value, getter, custom, or custom-index.  The state is currently tracked redundantly by two mechanisms - the custom getter function (m_getValue) is set to a special value to indicate the type (other than custom), and the type is also tracked by an enum - but only if cacheable.  Cacheability can typically be determined by the value of m_offset (this is invalidOffset if not cacheable).

* Internally, always track the type of the property using an enum value, PropertyType.
* Use m_offset to indicate cacheable.
* Keep the external interface (CachedPropertyType) unchanged.
* Better pack data into the m_data union.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.