[Webkit-unassigned] [Bug 119078] [GTK] [EFL] Enable tiled shadow blur for the inset shadows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119078


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207444|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-07-26 14:26:03 PST ---
(From update of attachment 207444)
View in context: https://bugs.webkit.org/attachment.cgi?id=207444&action=review

Nice. Just a couple suggestions before landing.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1054
> +    if (!roundedHoleRect.radii().isZero())
> +        path.addRoundedRect(roundedHoleRect);
> +    else
> +        path.addRect(roundedHoleRect.rect());

I wonder if this optimization should go into Path.cpp eventually?

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1061
> +    setFillRule(RULE_EVENODD);
> +    setFillColor(color, colorSpace);

I think that instead of setting the fill rule and color for the GraphicsContext you should just set them for the Cairo context. That way you can use cairo_save/cairo_restore, instead of oldFillRule and oldFillColor.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1065
> +        ShadowBlur& shadow = platformContext()->shadowBlur();
> +        shadow.drawInsetShadow(this, rect, roundedHoleRect.rect(), roundedHoleRect.radii());

I think you can avoid the temporary and move this code to the very start of the method after the early return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.