[Webkit-unassigned] [Bug 119134] New: Merge viewport units/calcs conversion flags into fixed/percent flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119134

           Summary: Merge viewport units/calcs conversion flags into
                    fixed/percent flags
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, benjamin at webkit.org, akling at apple.com


Perhaps we want to merge https://chromium.googlesource.com/chromium/blink/+/ef4c6bc20eb31ea1900f2dd5a8420cd9b4566ba4

In CSSPrimitiveValue::computeLength, we decide which conversions to
allow based on a template parameter which is a bitwise OR of several
flags. Since viewport units are a <length> type (as per css3 values),
we should be converting them whenever we can convert to a fixed length.
This patch removes the ViewportPercentageConversion flag and enables the
conversion whenever we enable a fixed length conversion.
Similarly, we should also convert calcs with both percentage and length
components (the CalculatedConversion flag) whenever both are allowed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.