[Webkit-unassigned] [Bug 118185] Gmail reply email - Bold and Italic style get stuck

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118185





--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org>  2013-07-25 17:13:37 PST ---
(From update of attachment 207445)
View in context: https://bugs.webkit.org/attachment.cgi?id=207445&action=review

> LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html:19
> +    log("Above are the results with "+platform+" platform editing behavior");

It would have been better to print out the platform before the test starts.
Adding a blank line between each platform will also help.

> LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html:35
> +function log(text) {
> +    var newItem = document.createElement('ul');
> +    newItem.appendChild(document.createTextNode(text));
> +    var markupResultList = document.getElementsByTagName("ol")[0];
> +    markupResultList.appendChild(newItem);
> +}

Why don't we add this to editing.js and call it something like separateMarkupResultList()?
It's odd to modify the variable editing.js defines like this.

> LayoutTests/editing/style/toggle-style-bold-italic.html:36
> +function log(text) {
> +    var newItem = document.createElement('ul');
> +    newItem.appendChild(document.createTextNode(text));
> +    var markupResultList = document.getElementsByTagName("ol")[0];
> +    markupResultList.appendChild(newItem);
> +}

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.