[Webkit-unassigned] [Bug 119095] New: Web Inspector: fix inconsistent use of 0-based and 1-based line numbers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119095

           Summary: Web Inspector: fix inconsistent use of 0-based and
                    1-based line numbers
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: burg at cs.washington.edu
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com, graouts at apple.com


Throughout the backend there are ugly and confusing mixes of 0-based an 1-based line numbers. I propose standardizing on 0-based line numbers, and only changing the ordinal base (to 1-based) at the very outer layer of the frontend. This is mostly how things work now, but there are unnecessary exceptions.

Some particularly troublesome spots:

 * ScriptDebugServer - This whole file is a rat nest. It's not documented whether 0-based or 1-based line numbers are used to index breakpoints per-line. hasBreakpoint() is scary and manually changes ordinal bases.

 * Timeline event line numbers are 1-based in the inspector protocol.

 * ConsoleMessage stack trace line numbers are 1-based.

Chime in if there are more places to fix.

Fixing:

 * If line numbers must be used as keys, then use an OrdinalNumber instead of 0- or 1-based line numbers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.