[Webkit-unassigned] [Bug 118185] Gmail reply email - Bold and Italic style get stuck

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118185





--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2013-07-25 00:28:01 PST ---
(From update of attachment 207435)
View in context: https://bugs.webkit.org/attachment.cgi?id=207435&action=review

The tests read much better but there are still some issues.

> LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html:13
> +test('win');
> +test('unix');

Don't we need to reset the content before each test?
Also, if we're testing both win & unix editing behaviors, we might as well as test mac editing behavior as well.

> LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html:17
> +if (window.internals)
> +internals.settings.setEditingBehavior(platform);
> +runDumpAsTextEditingTest(true);

Let's indent the function definition & the statement inside if.

> LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html:24
> +execSelectAllCommand();
> +execBoldCommand();
> +execItalicCommand();
> +execBoldCommand();
> +execItalicCommand();

Indentation.

> LayoutTests/editing/style/toggle-style-bold-italic.html:26
> +test('win');
> +test('unix');
> +function test(platform) {
> +if (window.internals)
> +internals.settings.setEditingBehavior(platform);
> +runDumpAsTextEditingTest(true);
> +}
> +function editingTest() {
> +execSelectAllCommand();
> +execBoldCommand();
> +execItalicCommand();
> +execBoldCommand();
> +execItalicCommand();
> +}

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.