[Webkit-unassigned] [Bug 119063] HistoryController: setting the pageScaleFactor and scrollPoint properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119063





--- Comment #3 from Brady Eidson <beidson at apple.com>  2013-07-24 15:50:22 PST ---
(In reply to comment #2)
> (From update of attachment 207409 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207409&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> You should either remove the entire line or state "No new tests needed because of foo....". Leaving the (OOPS!) here is wrong ;) .

Correction - You should either add tests, explain what tests cover this already, or explain why tests are not possible.

It's not okay to just remove this line without explanation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.