[Webkit-unassigned] [Bug 119025] Rename WebColorChooserProxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119025





--- Comment #8 from Ruth Fong <ruthiecftg at gmail.com>  2013-07-24 14:42:05 PST ---
(From update of attachment 207410)
View in context: https://bugs.webkit.org/attachment.cgi?id=207410&action=review

>>> Source/WebKit2/UIProcess/PageClient.h:190
>>> +    virtual PassRefPtr<WebColorPickerUI> createColorChooserProxy(WebPageProxy*, const WebCore::Color& initialColor, const WebCore::IntRect&) = 0;
>> 
>> This method is poorly named now, isn't it?
> 
> And is there any advantage to calling the new object WebColorPickerUI instead of WebColorPicker, considering that the abstract concept of a WebColorPicker encapsulates more than just its UI?

I think that the WebColorPicker(UI) object does represent UI representation of the color picker, whereas the WebColorChooser is the abstract representation for the <input type='color'> object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.