[Webkit-unassigned] [Bug 119055] New: Document::setContentLanguage should not call styleResolverChanged

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 12:24:53 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119055

           Summary: Document::setContentLanguage should not call
                    styleResolverChanged
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: hyatt at apple.com, ap at webkit.org, bdakin at apple.com,
                    simon.fraser at apple.com, dino at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/669007b54d9434eac10d50bc0981ad1dd6970e33

Document::setContentLanguage was calling styleResolverChanged just to update the root
style so we'll go through StyleResolver::styleForDocument which does not appear to be needed.
We only need to Force a recalc on the whole document so all the lang and locale related styles
are picked correctly.

This code came from https://bugs.webkit.org/show_bug.cgi?id=76701 where it was originally
recalcStyle(Force) in the patch and then through a series of review confusions it ended up as
a call to update the entire style resolver instead of just scheduling a forced style recalc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list