[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #22 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-24 05:30:12 PST ---
(In reply to comment #21)
> (In reply to comment #17)
> > Thanks for working on this! As an uzbl developer, is see a few things missing. It would be nice to have the "realm" if possible for the request; the host and/or URI might not be unique enough. 
> 
> I'm not quite sure what you mean by "realm", could you expand a bit on how you would like to see this implemented? 

The realm is available in the WebCore::AuthenticationChallenge. note that the user should be able to build the exact same auth dialog that wk uses by default with the public API.

> > Second, a credentials property would be nice for the request class and username/password/persistence on the credentials class. 
> 
> Sure, I could add properties for these, thats not a problem. Any comments/objections from Carlos, Martin or Gustavo?

I don't see why we need a property in the request, the credential object is not going to change and it's created on demand (at least in the current patch). The credential class is a boxed type not a gobject, think about it like a struct with a GType.

> > Is there documentation for where WebKit stores credentials or is it just "see libsecret docs"? An option in WebKitSettings along the lines of "enable-credential-storage" would be appreciated as well if possible.
> 
> webkit_authentication_request_can_save_credentials() in the request class seems to be what you are looking for - credentials are saved if the library support is available and we are not in private browsing mode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.