[Webkit-unassigned] [Bug 119030] New: Move platform-specific implementation of the color picker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 23 17:04:48 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119030

           Summary: Move platform-specific implementation of the color
                    picker
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ruthiecftg at gmail.com
                CC: beidson at apple.com, gyuyoung.kim at samsung.com,
                    jonlee at apple.com, ky0.choi at samsung.com


In bug 95058, a first WK2 implementation for <input type='color'> was outlined. However, in bug 61276, there will be some architectural changes that require changing the assumptions of the previous implementation.

Most notably, bug 61276 does not assume that WebPageProxy::showColorChooser is only called when m_colorChooser is null. showColorChooser will be called anytime an <input type='color'> element is activated (in ColorInputType.cpp).

To keep WebPageProxy cross-platform and to continue supporting the implementation put in place in bug 95058 as best as possible, parts of showColorChooser will be refactored into new private function like boolean useLegacyColorPicker() that will return false in WebPageProxy. A platform-specific WebPageProxySamsung will be created and the refactored useLegacyColorPicker() will be moved here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list