[Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118445





--- Comment #25 from Arunprasad Rajkumar <arurajku at cisco.com>  2013-07-23 06:10:06 PST ---
(In reply to comment #24)
> (In reply to comment #23)
> > (In reply to comment #22)
> > > (In reply to comment #20)
> > > > (In reply to comment #19)
> > > > > If you can make due with the keycodes outside of what Qt uses >255 <0x01000000. We could pass them through as there is no overlap. Though I think the best solution would be a setting to let us know were are in CE mode.
> > > > 
> > > > I'm getting your point :) But I'm sure adding a new property to a Qt's QKeyEvent is a painful job, because WebKit has to wait until the stable Qt release(with the change).
> > > > 
> > > Right, but perhaps you could use the existing nativeVirtualKeyCode field then.
> > 
> > Yeah, I too thought the same, but will it cause any confusion to the one who is seeing the code?
> > 
> > I know that 2 properties like nativeVirtualKeyCode, nativeScanCode are there. But what value it holds in X11/Windows ..?
> > 
> > I'm thinking like incase of Windows for left arrow key, 
> > nativeVirtualKeyCode = VK_LEFT
> > keycode = Qt::Key_Left
> > nativeScanCode = <some keyboard driver scan code>
> > 
> > Isn't it?
> 
> True, but since you are generating your own QKeyEvents you are essentially a new "native" source of key-events.

OK. Understood :)

>These values are usually only there for applications that need to detect keys not fully supported or detected by Qt, similar to your case.

So it the platformkeyboadreventqt.cpp, instead of returning keycode directly nativeVirtualKeyCode should be passed from default: case?

-default:
-  return keycode; 

+default:
+    return event->nativeVirtualKey();

Am I correct?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.