[Webkit-unassigned] [Bug 118468] [Curl] Download fails for certain urls.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 20 18:21:22 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=118468
Brent Fulgham <bfulgham at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #206260|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> 2013-07-20 18:21:16 PST ---
(From update of attachment 206260)
View in context: https://bugs.webkit.org/attachment.cgi?id=206260&action=review
Looks good. Please address my minor comments when you land!
> Source/WebCore/platform/network/curl/CurlDownload.cpp:352
> + String value = it->value;
This could be a const reference to avoid a copy.
> Source/WebCore/platform/network/curl/CurlDownload.cpp:353
> + String headerString(key);
You convert an AtomicString to a String in 351, then make a copy here. Why not just do "String headerString(it->key);"?
> Source/WebCore/platform/network/curl/CurlDownload.cpp:405
> + writeDataToFile(static_cast<char*>(data), size);
Why are you casting to a char*? The function signature is "const char*".
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list