[Webkit-unassigned] [Bug 118872] Mac port should run bison as part of ANGLE build process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118872


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207140|review?                     |review+
               Flag|                            |




--- Comment #11 from Mark Rowe (bdash) <mrowe at apple.com>  2013-07-19 14:11:44 PST ---
(From update of attachment 207140)
View in context: https://bugs.webkit.org/attachment.cgi?id=207140&action=review

r=me with the two minor issues.

> Source/ThirdParty/ANGLE/ChangeLog:8
> +        * ANGLE.xcodeproj/project.pbxproj: Made Derived Sources target which calls DerivedSources.make, moved generated files into Derived Sources group.

It'd be good to wrap this line somewhere so it's not dramatically longer than the rest of the lines in this file.

> Source/ThirdParty/ANGLE/DerivedSources.make:15
> +#     documentation and/or other materials provided with the distribution.
> +# 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> +#     its contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#

This is an old version of an old license we used to use. Take a look at Source/WebCore/LICENSE-APPLE for the current license.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.