[Webkit-unassigned] [Bug 99525] Spatial Navigation handling of space key in <select> appears to confuse listIndex and optionIndex

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 11:58:18 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=99525


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207132|commit-queue?               |commit-queue+
               Flag|                            |




--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org>  2013-07-19 11:58:13 PST ---
(From update of attachment 207132)
View in context: https://bugs.webkit.org/attachment.cgi?id=207132&action=review

Looks good. I can cq+ this one. Thanks.

> LayoutTests/fast/spatial-navigation/snav-multiple-select-optgroup.html:49
> +    function sendKeyAndCheckOptions(option0, option1, option2, option3)

Heh, this function doesn't actually "sendKey", it just checks options.

> Source/WebCore/ChangeLog:6
> +        HTMLSelect Element inherently contains the logic to focus option node and thus, implementing an explicit logic to find the focus index is not required.

Grammar: "implementing an explicit" => "implementing explicit"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list