[Webkit-unassigned] [Bug 118849] [Curl] Http response code 401 (Authentication required) is not handled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118849





--- Comment #4 from peavo at outlook.com  2013-07-19 05:55:18 PST ---
(In reply to comment #2)

Thanks for reviewing! Updated patch according to comments.


> View in context: https://bugs.webkit.org/attachment.cgi?id=207008&action=review
> 
> This looks cool, I've also wanted to implement this :)
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:299
> > +    err = curl_easy_getinfo(h, CURLINFO_EFFECTIVE_URL, &url);
> 
> The 'err'-s are only set but not used elsewhere, this could cause compiler warnings.
> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:823
> > +            // <rdar://problem/7174050> - For URLs that match the paths of those previously challenged for HTTP Basic authentication, 
> > +            // try and reuse the credential preemptively, as allowed by RFC 2617.
> 
> I don't know if we should keep this rdar url as we don't have a way to access it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.