[Webkit-unassigned] [Bug 117383] [GStreamer] Add handling for GstContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117383


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206898|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2013-07-17 10:40:21 PST ---
(From update of attachment 206898)
View in context: https://bugs.webkit.org/attachment.cgi?id=206898&action=review

Seems reasonable, but I think a smart pointer is the way to go here.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:156
> +    GstStructure* s2 = reinterpret_cast<GstStructure*>(userData);

Please don't use obscure abbreviations for variable names.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:269
> +        gst_context_unref(m_context);

Looks like this could be a RefPtr specialization which would allow you to avoid the initialization and destruction of this member.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:858
> +            s1 = gst_context_get_structure(newContext);
> +            s2 = gst_context_writable_structure(m_context);

Please make these variable names real words and declare them when you first define them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.