[Webkit-unassigned] [Bug 118759] [EFL] Calling ewk_settings_application_cache_path_set() more than once should have no effect.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118759


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryuan.choi at samsung.com




--- Comment #19 from Christophe Dumez <dchris at gmail.com>  2013-07-17 03:20:03 PST ---
(In reply to comment #17)
> (From update of attachment 206870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206870&action=review
> 
> >>>>>> Source/WebKit/efl/tests/test_ewk_setting.cpp:123
> >>>>>>      ewk_settings_application_cache_path_set("~/data/webkitApp");
> >>>>> 
> >>>>> the returned value should be tested, right?
> >>>> 
> >>>> s/tested/checked
> >>> 
> >>> This is the first time we call it and the path does not change? Why? Who calls it first?
> >> 
> >> Done
> > 
> > It is initialized in ewk_init() which is defined in ewk_main.cpp and is called from SetUp method of EWKTestEnvironment.
> 
> Well then, why is there such API at all if it will NEVER work?

There are 2 solutions:
1. Stop setting the app cache path in ewk main and let the app set the path:
Pros: The app can use another path than the default one
Cons: This is a behavior change and app cache will be disabled unless applications are updated to set the app cache path.

2. Remove this public API function
Pros: No behavior change.
Cons: The app cannot change the app cache path

I would go for 1 because this is WebKit1 and it is in maintenance mode. However, gyuyoung / ryuan may have a different opinion. I'll let them decide :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.