[Webkit-unassigned] [Bug 118599] Replace MathML pixel tests by reftests

Tue Jul 16 09:01:42 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=118599

--- Comment #13 from chris fleizach <cfleizach at apple.com>  2013-07-16 09:01:49 PST ---
(From update of attachment 206771)
View in context: https://bugs.webkit.org/attachment.cgi?id=206771&action=review

> LayoutTests/mathml/presentation/attributes1-expected-mismatch.html:12
> +	<mn>1</mn>

bad indendation

> LayoutTests/mathml/presentation/attributes1.html:1
> +<!doctype html>

can we make the names more descriptive, so if something fails the title will give away what should be looked at
so this would be attributes-style.

> LayoutTests/mathml/presentation/attributes2.html:1
> +<!doctype html>

attributes-background-color.html

> LayoutTests/mathml/presentation/attributes2.html:14
> +      <math>

bad indentation of <math> in comparison to children tags

> LayoutTests/mathml/presentation/attributes2.html:29
> +      <math mathbackground="orange">

ditto

> LayoutTests/mathml/presentation/attributes3.html:1
> +<!doctype html>

attributes-mathsize.html

> LayoutTests/mathml/presentation/attributes4-expected.html:14
> +	 "U+1D468 MATHEMATICAL BOLD ITALIC CAPITAL A") but WebKit implementation

but "the" WebKit imple...

> LayoutTests/mathml/presentation/attributes4.html:2
> +<html>

attributes-mathvariant.html

> LayoutTests/mathml/presentation/attributes4.html:10
> +	 single-char mi elements and "normal" otherwise. -->

single-char <mi> elements

> LayoutTests/mathml/presentation/attributes5-expected.html:9
> +    <!-- This only draws the background boxes since the x is hidden. -->

what X are you referring to here? are you referring to the content inside the tag?

> LayoutTests/mathml/presentation/attributes5.html:3
> +  <head>

attributes-display.html

> LayoutTests/mathml/presentation/attributes5.html:27
> +		  background: blue;">

ditto for indendation

> LayoutTests/mathml/presentation/bug95015-expected.html:10
> +    <!-- The msubsup should be in supscript and so hidden by the red

should be in "a" subscript, so "it should be" hidden by..

> LayoutTests/mathml/presentation/bug95015.html:10
> +    <!-- The msubsup should be in supscript and so hidden by the red

ditto for comment

> LayoutTests/mathml/presentation/bug95404-expected.html:16
> +		  background: red; width: 100%;">

are you wrapping to 80 chars for every line? it seems like a lot of these lines would be easier to read on one line

> LayoutTests/mathml/presentation/scripts1.html:2
> +<html>

this probably deserves two tests
scripts-underover
scripts-supsub

> LayoutTests/mathml/presentation/scripts1.html:208
> +	   not currently implement scriptlevel and only sets the size to

bug number?

> LayoutTests/mathml/presentation/scripts2.html:2
> +<html>

scripts-fontsize

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.