[Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103771





--- Comment #59 from Brendan Long <b.long at cablelabs.com>  2013-07-16 08:29:45 PST ---
(In reply to comment #58)
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1728
> > +    if (webkitGstCheckVersion(1, 1, 2)) {
> 
> Why not using the GST_CHECK_VERSION macro? Doing the test at build time would allow EWS to pass I think. We have no EWS with gst 1.1.2 yet though. Perhaps it's too early to bump the dep in our jhbuild moduleset too.

The EWS builds are failing because they need the WebVTTParser patch. For building, all that matters is that we're on GStreamer 1.0.

The runtime check is because before that version, the API is fine, but we'll get crashes and lockups, so I wanted things to work in the case where someone builds against 1.1.2 and then runs against 1.1.1. I guess that's not common, but that was the idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.