[Webkit-unassigned] [Bug 118721] [EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2UnitTestBase.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118721





--- Comment #4 from Donggwan Kim <donggwan.kim at samsung.com>  2013-07-16 04:33:15 PST ---
(In reply to comment #2)
> (From update of attachment 206746 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206746&action=review
> 
> > Source/WebKit2/ChangeLog:7
> > +
> 
> Missing Changelog.
Done.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:85
> > +static int compareHostNames(const void* hostName1, const void* hostName2)
> 
> Could you explain why some static functions are moved to EWK2CookieManagerTest while others are not?
I made a mistake. I will move all the missed static functions to EWK2CookieManagerTest and update the patch again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.