[Webkit-unassigned] [Bug 106817] [CSS Regions] Selecting text inside + outside regions does not work properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106817





--- Comment #20 from Alexandru Chiculita <achicu at adobe.com>  2013-07-16 02:53:36 PST ---
(From update of attachment 206470)
View in context: https://bugs.webkit.org/attachment.cgi?id=206470&action=review

> Source/WebCore/dom/Range.cpp:1070
> +        if (!renderer || (startRenderer && (renderer->flowThreadContainingBlock() != startRenderer->flowThreadContainingBlock())))

1. It might be worth storing the startRenderer->flowThreadContainingBlock on the stack before entering the loop.
2. What if the start node has no renderer? Should we better wait until the first node with a renderer and use that as the reference flow thread?
3. What happens with objects that have display:none? It looks like "!renderer" will change the behavior for that case.

> Source/WebCore/editing/FrameSelection.cpp:257
> +    if (!atSameFlowThread(base, newExtent))

Should we better patch FrameSelection::setSelection instead? Looks like other functions call that one and might bypass your check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.