[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117834





--- Comment #28 from Krzysztof Czech <k.czech at samsung.com>  2013-07-16 02:16:58 PST ---
> 
> This could take a const char* in argument and return a CString. It does not look like we need a String at all (inside the function or the callers).

There's one place when I need return String. It's an equalIgnoringCase function. It does not take two raw chars. I will have to convert one of those params to String.

> 
> Also, I find the name a bit confusing because it sounds like it 'sets' something. How about getAttributeSetValueForId() ?

Sounds good to me.
> 
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:56
> > +static String atkAttributeSetValueForId(AtkObject* accessible, const String& id)
> 
Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.