[Webkit-unassigned] [Bug 118717] [EFL][WK2] EWK2BackForwardListTest should be defined by inheriting from EWK2UnitTestBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118717


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206735|review?                     |review+
               Flag|                            |




--- Comment #2 from Christophe Dumez <dchris at gmail.com>  2013-07-16 01:07:42 PST ---
(From update of attachment 206735)
View in context: https://bugs.webkit.org/attachment.cgi?id=206735&action=review

r=me with nits.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:63
> +    inline void checkItem(Ewk_Back_Forward_List_Item* item, const char* title, const char* url, const char* originalURL)

Please remove the "inline" here and below. They likely don't bring anything here since the methods are implemented in the body of the class declaration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.