[Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 16 00:12:55 PDT 2013


--- Comment #58 from Philippe Normand <pnormand at igalia.com>  2013-07-16 00:13:16 PST ---
(From update of attachment 206687)
View in context: https://bugs.webkit.org/attachment.cgi?id=206687&action=review

Haven't done a full review yet, just a question:

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1728
> +    if (webkitGstCheckVersion(1, 1, 2)) {

Why not using the GST_CHECK_VERSION macro? Doing the test at build time would allow EWS to pass I think. We have no EWS with gst 1.1.2 yet though. Perhaps it's too early to bump the dep in our jhbuild moduleset too.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list