[Webkit-unassigned] [Bug 105866] [GTK] TestInspectorServer unit test is timing out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 08:04:17 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=105866


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206654|review?                     |review-
               Flag|                            |




--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2013-07-15 08:05:09 PST ---
(From update of attachment 206654)
View in context: https://bugs.webkit.org/attachment.cgi?id=206654&action=review

r- because we should move copying of files to the build system

> Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp:48
> +    // Overwrite WEBKIT_INSPECTOR_SERVER_PATH variable to point to inspector resources folder.
> +    const gchar* inspectorResourcesPath = g_getenv("WEBKIT_INSPECTOR_PATH");    
> +    g_setenv("WEBKIT_INSPECTOR_SERVER_PATH", inspectorResourcesPath, TRUE);

It makes sense to have this variable being set here, but when you say overwrite, do you mean the variable is already set but set to the wrong path?

> Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp:55
> +    // Copy inspectorPageIndex.html to inspector resources folder
> +    GOwnPtr<char> sourcePath(g_build_filename(WEBKIT_SRC_DIR, "Source", "WebKit2", "UIProcess", "InspectorServer", "front-end", "inspectorPageIndex.html", NULL));
> +    GRefPtr<GFile> source = adoptGRef(g_file_new_for_path(sourcePath.get()));
> +    GOwnPtr<char> destinationPath(g_build_filename(inspectorResourcesPath, "inspectorPageIndex.html", NULL));
> +    GRefPtr<GFile> destination = adoptGRef(g_file_new_for_path(destinationPath.get()));
> +    g_file_copy(source.get(), destination.get(), G_FILE_COPY_OVERWRITE, NULL, NULL, NULL, NULL); 

We should do this in the build system like we do for that other bits, instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list