[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 04:52:01 PDT 2013


--- Comment #23 from Christophe Dumez <dchris at gmail.com>  2013-07-15 04:52:58 PST ---
(From update of attachment 206526)
View in context: https://bugs.webkit.org/attachment.cgi?id=206526&action=review

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:54
> +static String atkAttributeSetValueForId(AtkObject* accessible, const String& id)

This could take a const char* in argument and return a CString. It does not look like we need a String at all (inside the function or the callers).

Also, I find the name a bit confusing because it sounds like it 'sets' something. How about getAttributeSetValueForId() ?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:56
> +static String atkAttributeSetValueForId(AtkObject* accessible, const String& id)

Same comments as for DRT.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list