[Webkit-unassigned] [Bug 118626] New: Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 16:36:02 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118626

           Summary: Introduce non-virtual Node::isFocusable and virtual
                    rendererIsFocusable
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: koivisto at iki.fi, tkent at chromium.org, akling at apple.com,
                    jonlee at apple.com


Consider merging https://chromium.googlesource.com/chromium/blink/+/94f9474455c2f83c606293c2608c0db8d266ada6

Before this patch, there were two virtual methods Node::isFocusable and
Node::supportsFocus. This patch renames isFocusable to rendererIsFocusable, and
introduces a new non-virtual method isFocusable which calls supportsFocus and
rendererIsFocusable.

The motivation is to clarify the purposes of the two virtual methods and
provide a central place for universal checks on focusability, such as whether
the node is in the document and non-inert (to be added later).

This patch is just a refactoring and should not change behavior.

Also see https://chromium.googlesource.com/chromium/blink/+/a21759964af400159c6ef86c57a7b677202bbffa

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list