[Webkit-unassigned] [Bug 91742] check-webkit-style crashes with OSError exception if SVN is not installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91742





--- Comment #11 from Emanuele Aina <emanuele.aina at collabora.com>  2013-07-12 04:19:28 PST ---
(In reply to comment #8)
> The patch is "fine" as is.  But it's not immediately clear to me what other callers might expect.  If you think all callers want this behavior than this is fine (we'd still like a unittest).  If you think that some might not, then it makes more sense to add the is_installed() helper instead.

Looking at the callers I don't feel that differentiating the two cases would give any benefit: they all seem to call the check to avoid invoking the SCM outside of a working directory so checking for the SCM availabity in in_working_directory() seems to make sense for all of them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.