[Webkit-unassigned] [Bug 97122] JS binding through JSC API is much slower than binding through WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 11 14:31:32 PDT 2013


--- Comment #4 from Geoffrey Garen <ggaren at apple.com>  2013-07-11 14:33:33 PST ---
One thing I see here is that JSWrapper::unwrap unnecessarily checks for null and calls JSValueToObject. It should just ASSERT non-null and ASSERT JSValueIsObjectOfClass, since this is guaranteed by the code generator. Then, it should static_cast to JSObjectRef.

This is not very important, since it's only test code, but if you're going to this piece of the test infrastructure for performance investigations, you should optimize it, so we don't get bogus results.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list