[Webkit-unassigned] [Bug 118513] Cache property access for JSC API static functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118513





--- Comment #5 from Yi Shen <max.hong.shen at gmail.com>  2013-07-11 11:19:20 PST ---
Thanks for review! Could you please explain a bit more about the 'arbitrary decisions' that you have mentioned? 

As I noticed that the JSCallbackObject<Parent>::staticFunctionGetter() always checks for cached or override property when it gets called.  So, I added a similar check before calling staticFunctionGetter() and pass the cached property to the property slot only if it exists. By doing this, we can cache the property access through tryCacheGetByID() (JITStubs.cpp). 

(In reply to comment #4)
> (From update of attachment 206340 [details])
> I don't think this is correct.
> 
> Client functions are allowed to make arbitrary decisions, and we can't assume they'll make the same decision each time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.