[Webkit-unassigned] [Bug 116317] [GTK] Metabug: Memory leak detection using valgrind

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 11 09:51:23 PDT 2013


--- Comment #17 from Brian Holt <brian.holt at samsung.com>  2013-07-11 09:53:23 PST ---
(In reply to comment #16)
> Nice. This is a big patch, so I haven't had time to review it. It's probably best when adding a lot of Python code to follow the style of the existing code though -- which is PEP8 as far as I know. Also, we typically don't abbreviate variable names and comments are complete sentences with periods at the end.

I've PEP8'ed the code so it passes the style check with the exception of the erroneous message about Popen.pid.  

I'll go back through all the code to check for variable names and comments, hopefully I can upload a new patch tomorrow.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list