[Webkit-unassigned] [Bug 117227] [WK1][GTK] Add support to use Threaded Coordinated Graphics.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117227





--- Comment #10 from Xabier Rodríguez Calvar <calvaris at igalia.com>  2013-07-11 03:21:34 PST ---
(From update of attachment 206078)
View in context: https://bugs.webkit.org/attachment.cgi?id=206078&action=review

I hope you don't mind this unofficial review as I am not a reviewer, but I spotted these issues in this very shallow check.

> Source/WebKit/gtk/ChangeLog:18
> +        * WebCoreSupport/AcceleratedCompositingContext.h:

I think ChangeLogs need a deeper explanation and specially this one.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:397
> +#endif // USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER_GL) !USE(COORDINATED_GRAPHICS_THREADED)

Nitpick: adding && to the comment as in the other case?

> Tools/GtkLauncher/main.c:502
> +#ifdef WTF_USE_COORDINATED_GRAPHICS_THREADED

USE(COORDINATED_GRAPHICS_THREADED) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.