[Webkit-unassigned] [Bug 118550] New: ANGLE should be updated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118550

           Summary: ANGLE should be updated
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: ANGLE
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: achristensen at apple.com
                CC: slewis at apple.com, dino at apple.com, noam at webkit.org


I have a working build of WebGL on Windows that uses most of ANGLE, so we should included the additional parts of ANGLE.  Before we do this, we may as well update to the latest revision.  

Blink is currently using r2184 of ANGLE.  We're currently using r1987.  I suggest we update to the latest revision of ANGLE, r2249.

Our current differences from the ANGLE repository are that we used Bison 2.4.2 instead of Bison 2.3 to generate glslang_tab and ExpressionParser cpp and h files, we put #if defined(_MSC_VER) around #pragma warning(disable: 4718) in DependencyGraph.cpp, and we include khrplatform.h instead of KHR/khrplatform.h in ShaderLang.h.  The current revision of ANGLE used Bison 2.4.2 to generate the files, so we won't need to rerun Bison.  We may as well keep the other two changes for now.

Updating to the latest revision moves DetectRecursion.cpp and DetectRecursion.h to DetectCallDepth.cpp and DetectCallDepth.h and adds builtin_symbol_table.cpp and builtin_symbol_table.h, so I've tried to do that by hand with all build systems.  "DetectRecursion" was also in Source\WebCore\WebCore.order, and I'm not sure what that is, so I may have broken whatever that is (Stephanie - you added that).  I would not be surprised if this first patch breaks build systems, but that's what the EWS system is for.  I don't want to land a patch that breaks anything.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.