[Webkit-unassigned] [Bug 117895] [v2.1.2] GTK2 build fails for undefined GDK_IS_X11_DISPLAY

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117895





--- Comment #19 from Kalev Lember <kalevlember at gmail.com>  2013-07-10 13:58:42 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > Perhaps this should be 
> > #if defined(GDK_WINDOWING_X11) && !defined(GDK_IS_X11_DISPLAY)
> > #define GDK_IS_X11_DISPLAY(display) 1
> > #else
> > #define GDK_IS_X11_DISPLAY(display) 0
> > #endif
> > 
> > for Windows and Mac?
> 
> Maybe... I honestly would not know if that's the right behavior or what the consequences are in this case :(

It should be fine to leave it undefined for other platforms.

In all the places that use it [1], GDK_IS_X11_DISPLAY() calls are always guarded with #ifdef GDK_WINDOWING_X11. As GTK+ 2 doesn't support multiple GDK backends, we can be sure that when GDK_WINDOWING_X11 is defined, it's an X11 build.

[1] ChromeClientGtk.cpp and BackingStoreCairo.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.