[Webkit-unassigned] [Bug 117895] [v2.1.2] GTK2 build fails for undefined GDK_IS_X11_DISPLAY

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117895





--- Comment #17 from Dominique Leuenberger <dimstar at opensuse.org>  2013-07-10 12:45:49 PST ---
(In reply to comment #16)
> (From update of attachment 206394 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206394&action=review
> 
> > Source/WebCore/platform/gtk/GtkVersioning.h:53
> > +#if defined(GDK_WINDOWING_X11) && !defined(GDK_IS_X11_DISPLAY)
> > +#define GDK_IS_X11_DISPLAY(dpy) 1
> > +#endif
> > +
> 
> Perhaps this should be 
> #if defined(GDK_WINDOWING_X11) && !defined(GDK_IS_X11_DISPLAY)
> #define GDK_IS_X11_DISPLAY(display) 1
> #else
> #define GDK_IS_X11_DISPLAY(display) 0
> #endif
> 
> for Windows and Mac?

Maybe... I honestly would not know if that's the right behavior or what the consequences are in this case :(

Question would probably be: are there webkit2/gtk2 windows/mac builds (I guess yes.. but then, seeing on how long and how often Gtk2 builds fail, I'm not sure)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.