[Webkit-unassigned] [Bug 118471] [texmap][GStreamer] upload onto the texture only the buffer to be painted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 11:50:54 PDT 2013


--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-09 11:52:54 PST ---
(From update of attachment 206326)
View in context: https://bugs.webkit.org/attachment.cgi?id=206326&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:371
> +    gst_buffer_map(m_buffer, &srcInfo, GST_MAP_READ);

Would it make sense or have any benefit to use gst_video_frame_map/unmap?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:384
> +    return texture;

This returns a PassRefPtr now, so this should return texture.release() to transfer the ownership to the caller.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list